sas accepted this revision.
sas added inline comments.
This revision is now accepted and ready to land.


================
Comment at: source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp:59
+  assert(m_num_registers ==
+         static_cast<unsigned>(m_registers_count[gpr_registers_count] +
+                               m_registers_count[fpr_registers_count] +
----------------
If you're gonna go with casting, I think using the same type as 
`m_num_registers` makes more sense.

    assert(m_num_registers == static_cast<uint32_t>(...));




https://reviews.llvm.org/D32137



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to