ravitheja marked 7 inline comments as done.
ravitheja added inline comments.


================
Comment at: include/lldb/API/SBProcess.h:251
+  ///     supported. To obtain the actual used trace options please
+  ///     use the GetTraceConfig API. For the custom parameters, only
+  ///     the parameters recognized by the target would be used and
----------------
clayborg wrote:
> Is GetTraceConfig an internal API? If so, lets not mention it here. You 
> general comments should suffice.
No, its not an internal API, so just to throw some light to it, Processor trace 
integration for Linux does not support all buffer sizes so we are rounding the 
buffer sizes to the nearest supported buffer size and through GetTraceConfig we 
plan to communicate the actual trace buffer size being.


https://reviews.llvm.org/D29581



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to