jasonmolenda wrote: The `const` explosion into ObjectFileELF is because in the override method `offset_t VirtualDataExtractor::SetData(const DataExtractor &data, lldb::offset_t offset, lldb::offset_t length)` I needed to call `data.GetSharedDataBuffer()` which is not a const method. I either needed to change this to a const method returning a const DataBufferSP, or I needed to change the DataExtractor::SetData method to take a non-const `DataExtractor` reference. maybe the latter would have been the smaller change, but DataBuffers don't really mutate in typical use so I chose that one first. Happy to revisit if anyone wants to see if it's a smaller impact.
https://github.com/llvm/llvm-project/pull/179858 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
