================
@@ -150,10 +176,12 @@ def get_frame_at_index(self, index):
if no frame exists at this index. The dictionary should
contain:
Required fields:
+
- idx (int): The synthetic frame index (0 for youngest/top frame)
----------------
vogelsgesang wrote:
Afaict, the
[create_frame_from_dict](https://github.com/llvm/llvm-project/blob/c43d1c5292d7d908fceae89e5d08016c16daac74/lldb/source/Plugins/SyntheticFrameProvider/ScriptedFrameProvider/ScriptedFrameProvider.cpp#L122C8-L122C30)
only parses `pc` and simply ignores all other properties.
Returning `{"idx": 12, "pc": 0x12345}` is equivalent to `{"pc": 0x12345}`. So,
afaik, we can simply stop mentioning `idx` here?
> re-order these to show just the ScriptedFrame object, then the integer
> representing the input frame index to reuse and finally the legacy dictionary.
done
> This {idx, pc} dictionary format is legacy so we have to keep supporting it
> unfortunately.
I didn't know that this was considered legacy functionality. Good to know.
Should we mark this as legacy in the documentation?
🤔 Actually... LLVM-22 is not out the door, yet.
This API didn't ship in an actual release, yet. So are we actually bound to
backwards-compatibility here? Or can we still remove it?
That could save us a few lines of code and a bit of maintenance in the long
run...
CC @JDevlieghere, since I don't actually know when the API stability guarantees
kick in (only with the official release? With the branch cut? at some other
point in time?)
https://github.com/llvm/llvm-project/pull/179996
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
