charles-zablit wrote:

https://github.com/swiftlang/llvm-project/pull/12266 fails because `%lldb-dap` 
in 
[`lldb/test/Shell/DAP/TestSTDINConsole.test`](https://github.com/charles-zablit/llvm-project/blob/f0b409cfa87549e8581717dc9fc80856a935f43d/lldb/test/Shell/DAP/TestSTDINConsole.test)
 is not expanded correctly.

When looking into the substitutions I noticed that both `lldb-dap` and 
`lldb-test` were the only tools which did not have the a proper `ToolSubst`. 
Changing to using `ToolSubst` fixes the solution in swiftlang and did not 
impact llvm/llvm-project, I thought it was a bug in llvm/llvm-project. Maybe 
that's not the correct solution.

Should we revert this, close https://github.com/llvm/llvm-project/pull/179992 
and look for the issue in swiftlang instead?

https://github.com/llvm/llvm-project/pull/179685
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to