https://github.com/DavidSpickett commented:
I can't be the approver on this, I can only comment on the use of existing LLDB infrastructure and not on architecture specific details. So you will need approval from a FreeBSD person, especially as this is a new port. I am suspicious of all the conversion going on. I await your explanation on that. For you to claim support, we need to see that you are able to run `check-lldb` and have reasonable results. Ideally there would be no failures, and no major features skipped for reasons under LLDB's control. E.g. lack of hardware breakpoint support is fine, as long as it's because FreeBSD has not implemented and/or stabailised it yet. The definition of "major" is up to reviewers but you can also present your own assessment of the results of course. If you cannot present good enough results, that does not mean this PR cannot be accepted, but we will need to see more PRs to fix the problems before the platform can be claimed to be "supported". We have a few experimentally supported platforms, it's not unusual. Where the bar lies for this PR to be accepted on its own, that lies with the other reviewers. https://github.com/llvm/llvm-project/pull/180549 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
