DavidSpickett wrote: I would be very careful citing what, at a glance, appears to be the source code of a GPL licensed project. In this case I think what you are trying to say is that like GDB, LLDB needs to have some form of kernel awareness. And looking at the code, it's 50% lldb APIs and 50% FreeBSD specifics so it's fine but you can understand why I want people to be careful about this.
Perhaps that file was added by a FreeBSD contributor but still, I see GDB in the path and immediately I'm wondering. And there are some in the community who for professional reasons will not go near GPL code, so this is going to cut down your potential reviewers, if it is the case that the file is important context. Besides all that, I'm not sure how that file is relevant to us as reviewers in LLDB. So please expand on that. Perhaps you want to highlight that this is the first thing that needed to be done, as was done for your GDB port. Perhaps you want to say that it uses the same interfaces as the GDB port, and therefore there is prior art for that approach. In which case tell us about that in your own words. What's important for us here is what features this code enables. Or does not enable, as you have already mentioned with the trap handler. https://github.com/llvm/llvm-project/pull/180669 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
