mchoo7 wrote:

> 
> Besides all that, I'm not sure how that file is relevant to us as reviewers 
> in LLDB. So please expand on that. Perhaps you want to highlight that this is 
> the first thing that needed to be done, as was done for your GDB port. 
> Perhaps you want to say that it uses the same interfaces as the GDB port, and 
> therefore there is prior art for that approach. In which case tell us about 
> that in your own words.
> 
> What's important for us here is what features this code enables. Or does not 
> enable, as you have already mentioned with the trap handler.

Updated PR description.

https://github.com/llvm/llvm-project/pull/180669
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to