================
@@ -589,14 +621,69 @@ bool ThreadList::WillResume(RunDirection &direction) {
           assert(thread_sp->GetCurrentPlan()->GetDirection() == direction);
           // You can't say "stop others" and also want yourself to be 
suspended.
           assert(thread_sp->GetCurrentPlan()->RunState() != eStateSuspended);
+
----------------
jimingham wrote:

How does this work in your new version where you discard all the 
ThreadPlanStepOverBreakpoint's at the start of WillResume?

In this `else` branch, you haven't yet run SetupToStepOverBreakpointIfNeeded on 
any of the threads yet.  That happens in the `if` branch for the one thread 
that was specially picked to run, but not more generally and anyway it hasn't 
happened on this branch of the if/else at all.

So there should be NO threads at this point that still have 
eKindStepOverBreakpoint plans on their plan stacks.   So far as I can tell, all 
this loop does anymore is look for "found_run_before_public_stop".

https://github.com/llvm/llvm-project/pull/180101
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to