================
@@ -849,15 +849,11 @@ bool DAP::HandleObject(const Message &M) {
auto handler_pos = request_handlers.find(req->command);
dispatcher.Set("client_data",
llvm::Twine("request_command:", req->command).str());
- if (handler_pos != request_handlers.end()) {
+ if (handler_pos != request_handlers.end())
handler_pos->second->Run(*req);
- return true; // Success
- }
-
- dispatcher.Set("error",
- llvm::Twine("unhandled-command:" + req->command).str());
- DAP_LOG(log, "error: unhandled command '{0}'", req->command);
- return false; // Fail
+ else
+ unknown_request_handler->Run(*req);
----------------
da-viper wrote:
```suggestion
UnknownRequestHandler handler(*this);
handler.BaseRequestHandler::Run(*req);
```
I don't think this needs to be a member variable we can just handle it here.
something like
https://github.com/llvm/llvm-project/pull/181109
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
