bzcheeseman wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
>
> You can test this locally with the following command:
> View the diff from clang-format here.
> ```diff
> diff --git a/lldb/include/lldb/Interpreter/OptionGroupVariable.h
> b/lldb/include/lldb/Interpreter/OptionGroupVariable.h
> index 4bea1eada..10340f629 100644
> --- a/lldb/include/lldb/Interpreter/OptionGroupVariable.h
> +++ b/lldb/include/lldb/Interpreter/OptionGroupVariable.h
> @@ -30,11 +30,11 @@ public:
> void OptionParsingStarting(ExecutionContext *execution_context) override;
>
> bool include_frame_options : 1,
> - show_args : 1, // Frame option only (include_frame_options == true)
> - show_recognized_args : 1, // Frame option only (include_frame_options
> ==
> - // true)
> - show_locals : 1, // Frame option only (include_frame_options == true)
> - show_globals : 1, // Frame option only (include_frame_options == true)
> + show_args : 1, // Frame option only (include_frame_options == true)
> + show_recognized_args : 1, // Frame option only (include_frame_options
> ==
> + // true)
> + show_locals : 1, // Frame option only (include_frame_options == true)
> + show_globals : 1, // Frame option only (include_frame_options == true)
> show_extended : 1, // Frame option only (include_frame_options == true)
> use_regex : 1, show_scope : 1, show_decl : 1;
> OptionValueString summary; // the name of a named summary
> diff --git a/lldb/source/Interpreter/OptionGroupVariable.cpp
> b/lldb/source/Interpreter/OptionGroupVariable.cpp
> index e97a4013c..91dfa11e7 100644
> --- a/lldb/source/Interpreter/OptionGroupVariable.cpp
> +++ b/lldb/source/Interpreter/OptionGroupVariable.cpp
> @@ -20,36 +20,106 @@ using namespace lldb_private;
> // if you add any options here, remember to update the counters in
> // OptionGroupVariable::GetNumDefinitions()
> static constexpr OptionDefinition g_variable_options[] = {
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "no-args", 'a',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "no-args",
> + 'a',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Omit function arguments."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "no-recognized-args", 't',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "no-recognized-args",
> + 't',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Omit recognized function arguments."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "no-locals", 'l',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "no-locals",
> + 'l',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Omit local variables."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "show-globals", 'g',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "show-globals",
> + 'g',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Show the current frame source file global and static variables."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "no-extended", 'e',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "no-extended",
> + 'e',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Omit extended variables."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "show-declaration", 'c',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "show-declaration",
> + 'c',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Show variable declaration information (source file and line where the "
> "variable was declared)."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "regex", 'r',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeRegularExpression,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "regex",
> + 'r',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeRegularExpression,
> "The <variable-name> argument for name lookups are regular
> expressions."},
> - {LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "scope", 's',
> - OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone,
> + {LLDB_OPT_SET_1 | LLDB_OPT_SET_2,
> + false,
> + "scope",
> + 's',
> + OptionParser::eNoArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeNone,
> "Show variable scope (argument, local, global, static)."},
> - {LLDB_OPT_SET_1, false, "summary", 'y', OptionParser::eRequiredArgument,
> - nullptr, {}, 0, eArgTypeName,
> + {LLDB_OPT_SET_1,
> + false,
> + "summary",
> + 'y',
> + OptionParser::eRequiredArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeName,
> "Specify the summary that the variable output should use."},
> - {LLDB_OPT_SET_2, false, "summary-string", 'z',
> - OptionParser::eRequiredArgument, nullptr, {}, 0, eArgTypeName,
> + {LLDB_OPT_SET_2,
> + false,
> + "summary-string",
> + 'z',
> + OptionParser::eRequiredArgument,
> + nullptr,
> + {},
> + 0,
> + eArgTypeName,
> "Specify a summary string to use to format the variable output."},
> };
>
> ```
Most of these changes are from code that wasn't touched. LLDB folks - let me
know if you'd prefer I reformat in this patch or leave it alone to avoid
polluting the change set with whitespace changes.
https://github.com/llvm/llvm-project/pull/181500
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
