JDevlieghere wrote: > Sorry about that @JDevlieghere . I thought I had addressed most of your > comments in the original PR. Maybe I misunderstood it when I saw you > mentioned that you only had nit comments and scripted plugin is reviewed by > other reviewer. Will keep in mind for future PR > > With regards to the new PR’s , they were failing in CI only on windows, which > I cannot test easily locally. So, was in urgency mode and wanted to quick > push PR’s to unblock other devs
No worries, I know you meant well. And for the build bot PRs, that's definitely the right thing to do 👍 https://github.com/llvm/llvm-project/pull/181498 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
