================
@@ -265,6 +265,25 @@ class Module : public std::enable_shared_from_this<Module>,
                                   lldb::SymbolType symbol_type,
                                   SymbolContextList &sc_list);
 
+  /// Find all symbols at a given file address.
+  ///
+  /// This function searches for symbols of a specified type that contain
+  /// the provided file address within their address range.
+  ///
+  /// \param[in] addr
+  ///     The file address to search for within symbol ranges.
+  ///
+  /// \param[in] symbol_type
+  ///     The type of symbols to search for (e.g., code, data, trampoline).
+  ///     Use lldb::eSymbolTypeAny to search all symbol types.
+  ///
+  /// \return
+  ///     A SymbolContextList containing all matching symbols that contain
+  ///     the specified address. Returns an empty list if no symbols are found.
+  SymbolContextList
+  FindSymbolsContainingFileAddress(const Address &addr,
----------------
clayborg wrote:

If you are passing in a `lldb_private::Address`, you don't need to specify 
"file address" in any of the comments of the function name. So this change 
would be better as:

```
  /// Find all symbols at a given address.
  ///
  /// This function searches for symbols of a specified type that contain
  /// the provided address within their address range.
  ///
  /// \param[in] addr
  ///     The address to search for within symbol ranges.
  ///
  /// \param[in] symbol_type
  ///     The type of symbols to search for (e.g., code, data, trampoline).
  ///     Use lldb::eSymbolTypeAny to search all symbol types.
  ///
  /// \return
  ///     A SymbolContextList containing all matching symbols that contain
  ///     the specified address. Returns an empty list if no symbols are found.
  SymbolContextList
  FindSymbolsContainingAddress(const Address &addr, lldb::SymbolType 
symbol_type);
```

https://github.com/llvm/llvm-project/pull/178695
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to