MaskRay wrote: > I'm not sure all the fields in MCTargetOptions logically make sense in > MCAsmInfo. Many, but not all of them seem out of place
MCAsmInfo just stores a pointer. The motivation is that createMCAsmInfo already takes a `MCTargetOptions` parameter. Both MIPS (for target ABI) and X86 (for `llvm-ml`) 's `createMCAsmInfo` use the parameter. If the target `MCAsmInfo` needs customization, taking `MCTargetOptions` is a natural choice. Then it's a natural choice for `MCContext` take the stored `MCTargetOptions` pointer in MCAsmInfo instead of from its own ctor. https://github.com/llvm/llvm-project/pull/180464 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
