https://github.com/Nerixyz approved this pull request.

This change looks good to me.

Regarding the additional error checks:

Does the caller abort once we return `eConnectionStatusError`? Could it be, 
that we marked a pending read, but the result wasn't ready yet when we checked? 
According to 
[`GetOverlappedResult`](https://learn.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-getoverlappedresult),
 it returns with `FALSE` and `ERROR_IO_INCOMPLETE` in that case, because we 
pass `bWait = FALSE`.

https://github.com/llvm/llvm-project/pull/183332
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to