Author: Med Ismail Bennani Date: 2026-02-25T23:46:40Z New Revision: b3ec476c702a1cd8ada8686a2be4fed7cccf81ef
URL: https://github.com/llvm/llvm-project/commit/b3ec476c702a1cd8ada8686a2be4fed7cccf81ef DIFF: https://github.com/llvm/llvm-project/commit/b3ec476c702a1cd8ada8686a2be4fed7cccf81ef.diff LOG: [lldb/test] Fix tests reading log from remote platform instead of host (#183413) Some tests are using logs to validate that a test behaves correctly however they used `platform shell cat {log}` to read the logfile. This doesn't work when running the testsuite against a remote platform since the logs are saved on the host's filesystem. This patch addresses those failures by making sure we read the log file from the host platform. Signed-off-by: Med Ismail Bennani <[email protected]> Added: Modified: lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py Removed: ################################################################################ diff --git a/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py b/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py index 2c32901452fb9..556fa8a6d4be9 100644 --- a/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py +++ b/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py @@ -17,7 +17,7 @@ def test(self): substrs=["`po` was unsuccessful, running `p` instead\n", "(Bad *) 0x"], ) self.filecheck( - f"platform shell cat {log}", __file__, f"-check-prefix=CHECK-EXPR" + f"platform shell -h -- cat {log}", __file__, f"-check-prefix=CHECK-EXPR" ) # CHECK-EXPR: Object description fallback due to error: could not evaluate print object function: expression interrupted @@ -26,6 +26,8 @@ def test(self): substrs=["`po` was unsuccessful, running `p` instead\n", "_lookHere = NO"], ) self.filecheck( - f"platform shell cat {log}", __file__, f"-check-prefix=CHECK-DWIM-PRINT" + f"platform shell -h -- cat {log}", + __file__, + f"-check-prefix=CHECK-DWIM-PRINT", ) # CHECK-DWIM-PRINT: Object description fallback due to error: could not evaluate print object function: expression interrupted diff --git a/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py b/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py index b6dc7637b45eb..d0162afd4595e 100644 --- a/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py +++ b/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py @@ -19,7 +19,9 @@ def test(self): "(Pair) pair = (f = 2, e = 3)", ], ) - self.filecheck(f"platform shell cat {log}", __file__, f"-check-prefix=CHECK-VO") + self.filecheck( + f"platform shel -h -- cat {log}", __file__, f"-check-prefix=CHECK-VO" + ) # CHECK-VO: Object description fallback due to error: not a pointer type self.expect( @@ -30,6 +32,6 @@ def test(self): ], ) self.filecheck( - f"platform shell cat {log}", __file__, f"-check-prefix=CHECK-EXPR" + f"platform shel -h -- cat {log}", __file__, f"-check-prefix=CHECK-EXPR" ) # CHECK-EXPR: Object description fallback due to error: not a pointer type _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
