llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) <details> <summary>Changes</summary> Now that https://github.com/llvm/llvm-project/pull/183332 is merged, we can remove the temporary Sleep when closing the ConPTY which mitigates a race condition. --- Full diff: https://github.com/llvm/llvm-project/pull/183539.diff 1 Files Affected: - (modified) lldb/source/Host/windows/PseudoConsole.cpp (-4) ``````````diff diff --git a/lldb/source/Host/windows/PseudoConsole.cpp b/lldb/source/Host/windows/PseudoConsole.cpp index 03ebabc2d8f75..da4b1310ea17c 100644 --- a/lldb/source/Host/windows/PseudoConsole.cpp +++ b/lldb/source/Host/windows/PseudoConsole.cpp @@ -138,10 +138,6 @@ bool PseudoConsole::IsConnected() const { } void PseudoConsole::Close() { - Sleep(50); // FIXME: This mitigates a race condition when closing the - // PseudoConsole. It's possible that there is still data in the - // pipe when we try to close it. We should wait until the data has - // been consumed. SetStopping(true); std::unique_lock<std::mutex> guard(m_mutex); if (m_conpty_handle != INVALID_HANDLE_VALUE) `````````` </details> https://github.com/llvm/llvm-project/pull/183539 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
