weliveindetail wrote: From my side the latest state is good to go. Are there any more questions or ideas for improvements?
Following up from inline comments. > You can enable PDB with TEST_WITH_PDB_DEBUG_INFO in API tests. @Nerixyz Thanks, that's exactly what I was looking for! I turned it into a debug-info test, used `TEST_WITH_PDB_DEBUG_INFO` to enable PDB and actively ignore the other formats right now. It works very well! > Are you sure this tests that we can find the PDB? By default, the API tests > build with DWARF, but when linking on Windows, LLD will also generate a PDB > with just the symbols (S_PUB32). So you will find a PDB, but the executable > itself has DWARF, which LLDB will use. Yes, the PDB was linked and LLDB discovered it with the SymbolLocator, but eventually it used the DWARF info to resolve the breakpoint. The new setup fixes that. DWARF is out of the loop and we go through `SymbolVendorPECOFF` as desired. > Ideally, there would be a check here that we use the expected PDB at the > right path. Verifying the path was an option, but I chose a different approach now. I added a test-case without the `plugin.symbol-locator.symstore.urls` and make sure it fails (i.e. br has no locs). The test-case for the local SymStore only adds the setting and checks that it works. I prefer this approach since it relies less on the underlying details. https://github.com/llvm/llvm-project/pull/183302 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
