https://github.com/DavidSpickett approved this pull request.
Yeah lldb's message makes it pretty clear. That's given me a lot of confidence in this change. On the grounds that: * FreeBSDKernelCore uses kvm to write to whatever it's been given. * If someone wants to enable writing to offline files then they'd have to extend kvm, not lldb. * Therefore it's fine for FreeBSDKernelCore to have this read-only setting that applies to all kvm powered access. LLDB shouldn't be checking "is this /dev/mem or not". (at least for as long as kvm is the only method of access) So this LGTM to merge as long as the release note is adjusted. https://github.com/llvm/llvm-project/pull/183553 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
