bulbazord wrote:

> Yes, that's right. I don't know if you reviewed this before or after I 
> reworked this PR. I didn't realize that the Python script interpreter plugin 
> was calling `GetShlibDir` during its initialization, hitting this exact 
> scenario. Anyway, the updated patch has an assert that should capture this 
> mistake, though it still only gets diagnosed at runtime.

Reviewed after, I think. It looks like you're not going through the plugin 
manager anymore? Either way the implementation looks ok to me. I can't think of 
how I would catch this at compile time.

https://github.com/llvm/llvm-project/pull/183637
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to