================
@@ -489,6 +480,9 @@ class PluginManager {
                                          const UUID *uuid,
                                          const ArchSpec *arch);
 
+  static FileSpec LocateSourceFile(const lldb::ModuleSP &module_sp,
----------------
rchamala wrote:

More flexibility. In the very original design an year back, I had ModuleSpec, 
but labath mentioned it be might be useful to have ModuleSP, so we can make it 
more flexible 
https://discourse.llvm.org/t/rfc-python-callback-for-source-file-resolution/83545/3?u=rahulvn389

"
His reasoning here is that if the callback wants to get the build id, it can 
always get it from the Module, but this way maybe it can get some additional 
information that wouldn’t be available otherwise. 
"

This made sense to me, so switched it to ModuleSP

https://github.com/llvm/llvm-project/pull/183674
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to