Author: Michael Buch Date: 2026-03-10T14:17:05Z New Revision: f0c7f0f8d4bdac7b1127946a7959b7f4217bfed9
URL: https://github.com/llvm/llvm-project/commit/f0c7f0f8d4bdac7b1127946a7959b7f4217bfed9 DIFF: https://github.com/llvm/llvm-project/commit/f0c7f0f8d4bdac7b1127946a7959b7f4217bfed9.diff LOG: [lldb][PlatformDarwin][NFC] Use formatv-style format string in Locate ExecutableScriptingResourcesFromDSYM warning message (#185640) About to make changes in this area and using `formatv` instead of `printf` style format specifiers makes those easier to follow. Added: Modified: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp index a7e28eb1bcc7e..c49bd69618227 100644 --- a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp +++ b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp @@ -250,24 +250,24 @@ FileSpecList PlatformDarwin::LocateExecutableScriptingResourcesFromDSYM( ? "conflicts with a keyword" : "contains reserved characters"; if (FileSystem::Instance().Exists(script_fspec)) - feedback_stream.Printf( - "warning: the symbol file '%s' contains a debug " + feedback_stream.Format( + "warning: the symbol file '{0}' contains a debug " "script. However, its name" - " '%s' %s and as such cannot be loaded. LLDB will" - " load '%s' instead. Consider removing the file with " + " '{1}' {2} and as such cannot be loaded. LLDB will" + " load '{3}' instead. Consider removing the file with " "the malformed name to" " eliminate this warning.\n", - symfile_spec.GetPath().c_str(), original_path_string.GetData(), - reason_for_complaint, path_string.GetData()); + symfile_spec.GetPath(), original_path_string.GetString(), + reason_for_complaint, path_string.GetString()); else - feedback_stream.Printf( - "warning: the symbol file '%s' contains a debug " + feedback_stream.Format( + "warning: the symbol file '{0}' contains a debug " "script. However, its name" - " %s and as such cannot be loaded. If you intend" - " to have this script loaded, please rename '%s' to " - "'%s' and retry.\n", - symfile_spec.GetPath().c_str(), reason_for_complaint, - original_path_string.GetData(), path_string.GetData()); + " {1} and as such cannot be loaded. If you intend" + " to have this script loaded, please rename '{2}' to " + "'{3}' and retry.\n", + symfile_spec.GetPath(), reason_for_complaint, + original_path_string.GetString(), path_string.GetString()); } if (FileSystem::Instance().Exists(script_fspec)) { _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
