https://github.com/Michael137 approved this pull request.
On the surface this makes sense. Though I do wonder if this will eventually need to be re-instated if we wanted to support more of the typed DWARF stack (https://dwarfstd.org/issues/140425.1.html) operations (though I don't know much about it). That being said, looks like we use `GetScalar` in plenty of the other operations, so making it consistent throughout the function makes sense. Was wondering where we could put an assert to confirm that the stack element in fact doesn't have a `CompilerType`. But can't quite see a single place where that would make sense https://github.com/llvm/llvm-project/pull/185841 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
