llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Minsoo Choo (mchoo7) <details> <summary>Changes</summary> `debugger.GetCommandInterpreter().IsInteractive()` doesn't necessarily mean that the debugger is running without `-b` or `--batch` flag. This caused an issue where the message isn't printed in any case. Remove the check so the message is always printed for now. Fixes: 9d9c7fc00bdddd72e78b19e9fbb6af9d07c2218b (#<!-- -->178027) --- Full diff: https://github.com/llvm/llvm-project/pull/187981.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp (-3) ``````````diff diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp index d1a4a1ebc47d7..da8e22caaa80f 100644 --- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp +++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp @@ -394,9 +394,6 @@ void ProcessFreeBSDKernelCore::PrintUnreadMessage() { Target &target = GetTarget(); Debugger &debugger = target.GetDebugger(); - if (!debugger.GetCommandInterpreter().IsInteractive()) - return; - Status error; // Find msgbufp symbol (pointer to message buffer) `````````` </details> https://github.com/llvm/llvm-project/pull/187981 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
