llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) <details> <summary>Changes</summary> Building libfoo.a twice (quickly) confuses the cache in ObjectContainerBSDArchive (which works only with second granularity), and causes the second test to fail due to accessing wrong parts of the file. I'm also making this a NO_DEBUG_INFO_TESTCASE as the debug info distinction is not particularly relevant for this test. Technically, this would be enough as the collision is between two debug info variants of the same test case, but SHARED_BUILD_TESTCASE=False seems like a more principled fix. --- Full diff: https://github.com/llvm/llvm-project/pull/188265.diff 1 Files Affected: - (modified) lldb/test/API/python_api/sbmodule/TestSBModule.py (+6) ``````````diff diff --git a/lldb/test/API/python_api/sbmodule/TestSBModule.py b/lldb/test/API/python_api/sbmodule/TestSBModule.py index 1e6cdefc8d8f0..69ff0b0a2e5dc 100644 --- a/lldb/test/API/python_api/sbmodule/TestSBModule.py +++ b/lldb/test/API/python_api/sbmodule/TestSBModule.py @@ -9,6 +9,12 @@ class SBModuleAPICase(TestBase): + + NO_DEBUG_INFO_TESTCASE = True + + # Shared build causes collisions in the ObjectArchive file cache + SHARED_BUILD_TESTCASE = False + def setUp(self): TestBase.setUp(self) self.background_pid = None `````````` </details> https://github.com/llvm/llvm-project/pull/188265 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
