Stefan =?utf-8?q?Gränitz?= <[email protected]>,
Stefan =?utf-8?q?Gränitz?= <[email protected]>,
Stefan =?utf-8?q?Gränitz?= <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
================
@@ -216,16 +167,57 @@ requestFileFromSymStoreServerHTTP(llvm::StringRef
base_url, llvm::StringRef key,
// Server has same directory structure with forward slashes as separators.
std::string source_url =
llvm::formatv("{0}/{1}/{2}/{1}", base_url, pdb_name, key);
- if (llvm::Error err = downloadFileHTTP(source_url, cache_file.str())) {
- LLDB_LOG_ERROR(log, std::move(err),
- "Failed to download from SymStore '{1}': {0}", source_url);
+
+ if (!llvm::HTTPClient::isAvailable()) {
+ Debugger::ReportWarning("HTTP client is not available");
----------------
Nerixyz wrote:
```suggestion
Debugger::ReportWarning("HTTP client is not available for SymStore
download");
```
To indicate why we need an HTTP client.
https://github.com/llvm/llvm-project/pull/187687
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
