Can you run the analyze deps script before and after this patch, and update the cmake files if any deps are no longer necessary? On Mon, Jun 26, 2017 at 8:24 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote:
> labath created this revision. > Herald added subscribers: mgorny, kubamracek. > > It had a dependency on StringConvert and file reading code, which is not > in Utility. I've replaced that code by equivalent llvm operations. > > I've added a unit test to demonstrate that parsing a file still works. > > > https://reviews.llvm.org/D34625 > > Files: > include/lldb/Breakpoint/Breakpoint.h > include/lldb/Breakpoint/BreakpointOptions.h > include/lldb/Core/Event.h > include/lldb/Core/SearchFilter.h > include/lldb/Core/StructuredData.h > include/lldb/Core/StructuredDataImpl.h > include/lldb/Core/TraceOptions.h > include/lldb/DataFormatters/TypeSummary.h > include/lldb/DataFormatters/TypeSynthetic.h > include/lldb/Host/XML.h > include/lldb/Interpreter/ScriptInterpreter.h > include/lldb/Target/InstrumentationRuntime.h > include/lldb/Target/InstrumentationRuntimeStopInfo.h > include/lldb/Target/Process.h > include/lldb/Target/StopInfo.h > include/lldb/Target/StructuredDataPlugin.h > include/lldb/Target/SystemRuntime.h > include/lldb/Target/Thread.h > include/lldb/Target/ThreadPlanPython.h > include/lldb/Utility/JSON.h > include/lldb/Utility/StructuredData.h > source/API/SBStructuredData.cpp > source/API/SBThread.cpp > source/API/SBThreadPlan.cpp > source/Core/CMakeLists.txt > source/Core/FormatEntity.cpp > source/Core/StructuredData.cpp > source/Host/macosx/Host.mm > source/Host/windows/Host.cpp > source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h > source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h > source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h > source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.h > > source/Plugins/InstrumentationRuntime/MainThreadChecker/MainThreadCheckerRuntime.h > source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.h > source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.h > source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp > source/Plugins/OperatingSystem/Python/OperatingSystemPython.h > source/Plugins/Process/Utility/DynamicRegisterInfo.cpp > source/Plugins/Process/Utility/DynamicRegisterInfo.h > source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h > > source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp > source/Plugins/Process/gdb-remote/ProcessGDBRemote.h > source/Plugins/Process/gdb-remote/ThreadGDBRemote.h > source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h > source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h > source/Target/Platform.cpp > source/Target/ThreadSpec.cpp > source/Utility/CMakeLists.txt > source/Utility/JSON.cpp > source/Utility/StructuredData.cpp > unittests/Core/CMakeLists.txt > unittests/Core/StructuredDataTest.cpp > unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp > unittests/Utility/CMakeLists.txt > unittests/Utility/Inputs/StructuredData-basic.json > unittests/Utility/StructuredDataTest.cpp > unittests/tools/lldb-server/tests/MessageObjects.cpp > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
