https://github.com/JDevlieghere approved this pull request.
LGTM. If we want to avoid duplicating the comment, we can hoist this out of the
if to have something like:
```
if (WIN32)
set(PYTHON_SBIN_LIBRARY_DIR ${Python3_LIBRARY_DIRS})
endif()
and then unconditionally add this:
```
target_link_directories(lldbPluginScriptInterpreterPython PUBLIC
${PYTHON_SBIN_LIBRARY_DIR}
```
Not sure if that works if the variable is empty. If not we can just wrap it in
an `if()` again (which makes this suggestion slightly less appealing)
https://github.com/llvm/llvm-project/pull/197185
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
