llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) <details> <summary>Changes</summary> Using the public stop is correct but too conservative: breakpoints changed during private stops are very likely to happen while the process has a public "running" state but a private "stopped" state. --- Full diff: https://github.com/llvm/llvm-project/pull/199639.diff 1 Files Affected: - (modified) lldb/source/Target/Process.cpp (+1-1) ``````````diff diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp index 39399480b0806..83c8f434e9a57 100644 --- a/lldb/source/Target/Process.cpp +++ b/lldb/source/Target/Process.cpp @@ -1602,7 +1602,7 @@ llvm::Error Process::ExecuteBreakpointSiteAction(BreakpointSite &site, BreakpointAction action, bool forbid_delay) { // Breakpoints immediately affect running processes, so do not delay them. - forbid_delay |= IsRunning(); + forbid_delay |= StateIsRunningState(GetPrivateState()); if (forbid_delay) if (llvm::Error E = FlushDelayedBreakpoints()) `````````` </details> https://github.com/llvm/llvm-project/pull/199639 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
