llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) <details> <summary>Changes</summary> These three tests pass when run against a remote-darwin platform backed by lldb-platform on device, but they may still legitimately fail on remote-linux / remote-windows / remote-freebsd / etc., so the blanket `remote=True` XFAIL is narrowed to non-Darwin remotes only. - TestAssertMessages.test_createTestTarget: was XFAIL on oslist=no_match(["linux"]) + remote=True. Add darwin_all to the no_match list so the XFAIL stays only on remote-windows / remote-freebsd / remote-netbsd / remote-android. - TestObjcOptimized.test_break: scope to non-Darwin remotes. - TestDebuggerAPI.test_CreateTarget_platform: scope to non-Darwin remotes (bug llvm/llvm-project#<!-- -->92419 still tracks the underlying issue on those platforms). --- Full diff: https://github.com/llvm/llvm-project/pull/200529.diff 3 Files Affected: - (modified) lldb/test/API/assert_messages_test/TestAssertMessages.py (+5-1) - (modified) lldb/test/API/lang/objc/objc-optimized/TestObjcOptimized.py (+5-1) - (modified) lldb/test/API/python_api/debugger/TestDebuggerAPI.py (+2) ``````````diff diff --git a/lldb/test/API/assert_messages_test/TestAssertMessages.py b/lldb/test/API/assert_messages_test/TestAssertMessages.py index 27d18e5ae99b9..45d3c184662f1 100644 --- a/lldb/test/API/assert_messages_test/TestAssertMessages.py +++ b/lldb/test/API/assert_messages_test/TestAssertMessages.py @@ -5,6 +5,7 @@ import lldb import lldbsuite.test.lldbutil as lldbutil +from lldbsuite.test import lldbplatform from lldbsuite.test.lldbtest import * from lldbsuite.test.decorators import * from textwrap import dedent @@ -23,7 +24,10 @@ def assert_expect_fails_with(self, cmd, expect_args, expected_msg): else: self.fail("Initial expect should have raised AssertionError!") - @expectedFailureAll(oslist=no_match(["linux"]), remote=True) + @expectedFailureAll( + oslist=no_match(["linux"] + lldbplatform.translate(lldbplatform.darwin_all)), + remote=True, + ) def test_createTestTarget(self): try: self.createTestTarget("doesnt_exist") diff --git a/lldb/test/API/lang/objc/objc-optimized/TestObjcOptimized.py b/lldb/test/API/lang/objc/objc-optimized/TestObjcOptimized.py index 387a3e11e0c0f..72c6b203842f0 100644 --- a/lldb/test/API/lang/objc/objc-optimized/TestObjcOptimized.py +++ b/lldb/test/API/lang/objc/objc-optimized/TestObjcOptimized.py @@ -9,6 +9,7 @@ import lldb import re +from lldbsuite.test import lldbplatform from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * from lldbsuite.test import lldbutil @@ -22,7 +23,10 @@ class ObjcOptimizedTestCase(TestBase): mymethod = "description" method_spec = "-[%s %s]" % (myclass, mymethod) - @expectedFailureAll(remote=True) + @expectedFailureAll( + oslist=no_match(lldbplatform.translate(lldbplatform.darwin_all)), + remote=True, + ) def test_break(self): """Test 'expr member' continues to work for optimized build.""" self.build() diff --git a/lldb/test/API/python_api/debugger/TestDebuggerAPI.py b/lldb/test/API/python_api/debugger/TestDebuggerAPI.py index 93ee52dc88ef8..488878b0436cd 100644 --- a/lldb/test/API/python_api/debugger/TestDebuggerAPI.py +++ b/lldb/test/API/python_api/debugger/TestDebuggerAPI.py @@ -4,6 +4,7 @@ import lldb +from lldbsuite.test import lldbplatform from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * from lldbsuite.test import lldbutil @@ -94,6 +95,7 @@ def get_cache_line_size(): self.assertEqual(get_cache_line_size(), new_cache_line_size) @expectedFailureAll( + oslist=no_match(lldbplatform.translate(lldbplatform.darwin_all)), remote=True, bugnumber="github.com/llvm/llvm-project/issues/92419", ) `````````` </details> https://github.com/llvm/llvm-project/pull/200529 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
