================
@@ -205,13 +205,16 @@ if(TARGET clang)
"LLDB_TEST_LIBCXX_ROOT_DIR to it.")
endif()
else()
- # We require libcxx for the test suite, so if we aren't building it,
- # provide a helpful error about how to resolve the situation.
+ # The LLDB test suite uses libc++ for many tests. If it isn't being
+ # built in-tree, warn and let the suite fall back to whatever libc++
+ # the compiler picks up by default (the system one on Darwin); the
+ # libc++-specific tests will be skipped or run against system libc++.
if(NOT LLDB_HAS_LIBCXX)
- message(SEND_ERROR
- "LLDB test suite requires libc++, but it is currently disabled. "
- "Please add `libcxx` to `LLVM_ENABLE_RUNTIMES` or disable tests via "
- "`LLDB_INCLUDE_TESTS=OFF`.")
+ message(WARNING
+ "LLDB test suite normally uses an in-tree libc++; it is currently "
----------------
medismailben wrote:
> What if I just want to run the non-libc++ specific tests?
I don't really see the point of adding `LLDB_ENABLE_LIBCXX_TESTS`. Instead of
setting that flag, the user should just not build libcxx. To me it makes things
more confusing.
https://github.com/llvm/llvm-project/pull/199262
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
