https://github.com/Teemperor updated https://github.com/llvm/llvm-project/pull/201075
>From a5dd1e7915bfb49c6a9df715efe0872b6326d488 Mon Sep 17 00:00:00 2001 From: Raphael Isemann <[email protected]> Date: Tue, 2 Jun 2026 10:04:28 +0100 Subject: [PATCH] [lldb][NFC] Don't use C++20 designated initializer This source triggers the `-Wc++20-designator` warning as we're still using C++ 17. --- .../SymbolFile/DWARF/XcodeSDKModuleTests.cpp | 82 +++++++++---------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp b/lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp index 50c37dcd4568e..40c29a6a1a0ec 100644 --- a/lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp +++ b/lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp @@ -276,59 +276,59 @@ TEST_P(SDKPathParsingMultiparamTests, TestSDKPathFromDebugInfo) { SDKPathParsingTestData sdkPathParsingTestCases[] = { /// Multiple CUs with a mix of internal and public SDKs - {.input_sdk_paths = - {"/Library/Developer/CommandLineTools/SDKs/MacOSX10.9.sdk", - "/invalid/path/to/something.invalid.sdk", - "/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.0.Internal.sdk", - "/Library/Developer/CommandLineTools/SDKs/MacOSX10.9.sdk"}, - .expect_mismatch = true, - .expect_internal_sdk = true, - .expect_sdk_path_pattern = "Internal.sdk"}, + {/* .input_sdk_paths = */ { + "/Library/Developer/CommandLineTools/SDKs/MacOSX10.9.sdk", + "/invalid/path/to/something.invalid.sdk", + "/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.0.Internal.sdk", + "/Library/Developer/CommandLineTools/SDKs/MacOSX10.9.sdk"}, + /* .expect_mismatch = */ true, + /* .expect_internal_sdk = */ true, + /* .expect_sdk_path_pattern = */ "Internal.sdk"}, /// Single CU with a public SDK - {.input_sdk_paths = - {"/Library/Developer/CommandLineTools/SDKs/MacOSX10.9.sdk"}, - .expect_mismatch = false, - .expect_internal_sdk = false, - .expect_sdk_path_pattern = "MacOSX10.9.sdk"}, + {/* .input_sdk_paths = */ { + "/Library/Developer/CommandLineTools/SDKs/MacOSX10.9.sdk"}, + /* .expect_mismatch = */ false, + /* .expect_internal_sdk = */ false, + /* .expect_sdk_path_pattern = */ "MacOSX10.9.sdk"}, /// Single CU with an internal SDK - {.input_sdk_paths = - {"/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.0.Internal.sdk"}, - .expect_mismatch = false, - .expect_internal_sdk = true, - .expect_sdk_path_pattern = "Internal.sdk"}, + {/* .input_sdk_paths = */ { + "/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.0.Internal.sdk"}, + /* .expect_mismatch = */ false, + /* .expect_internal_sdk = */ true, + /* .expect_sdk_path_pattern = */ "Internal.sdk"}, /// Two CUs with an internal SDK each - {.input_sdk_paths = - {"/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.0.Internal.sdk", - "/Library/Developer/CommandLineTools/SDKs/iPhoneOS12.9.Internal.sdk"}, - .expect_mismatch = false, - .expect_internal_sdk = true, - .expect_sdk_path_pattern = "Internal.sdk"}, + {/* .input_sdk_paths = */ { + "/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.0.Internal.sdk", + "/Library/Developer/CommandLineTools/SDKs/iPhoneOS12.9.Internal.sdk"}, + /* .expect_mismatch = */ false, + /* .expect_internal_sdk = */ true, + /* .expect_sdk_path_pattern = */ "Internal.sdk"}, /// Two CUs with a public (non-CommandLineTools) SDK each - {.input_sdk_paths = {"/Path/To/SDKs/iPhoneOS14.1.sdk", - "/Path/To/SDKs/MacOSX11.3.sdk"}, - .expect_mismatch = false, - .expect_internal_sdk = false, - .expect_sdk_path_pattern = "iPhoneOS14.1.sdk"}, + {/* .input_sdk_paths = */ {"/Path/To/SDKs/iPhoneOS14.1.sdk", + "/Path/To/SDKs/MacOSX11.3.sdk"}, + /* .expect_mismatch = */ false, + /* .expect_internal_sdk = */ false, + /* .expect_sdk_path_pattern = */ "iPhoneOS14.1.sdk"}, /// One CU with CommandLineTools and the other a public SDK - {.input_sdk_paths = - {"/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.1.sdk", - "/Path/To/SDKs/MacOSX11.3.sdk"}, - .expect_mismatch = false, - .expect_internal_sdk = false, - .expect_sdk_path_pattern = "iPhoneOS14.1.sdk"}, + {/* .input_sdk_paths = */ { + "/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.1.sdk", + "/Path/To/SDKs/MacOSX11.3.sdk"}, + /* .expect_mismatch = */ false, + /* .expect_internal_sdk = */ false, + /* .expect_sdk_path_pattern = */ "iPhoneOS14.1.sdk"}, /// One CU with CommandLineTools and the other an internal SDK - {.input_sdk_paths = - {"/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.1.sdk", - "/Path/To/SDKs/MacOSX11.3.Internal.sdk"}, - .expect_mismatch = true, - .expect_internal_sdk = true, - .expect_sdk_path_pattern = "iPhoneOS14.1.Internal.sdk"}, + {/* .input_sdk_paths = */ { + "/Library/Developer/CommandLineTools/SDKs/iPhoneOS14.1.sdk", + "/Path/To/SDKs/MacOSX11.3.Internal.sdk"}, + /* .expect_mismatch = */ true, + /* .expect_internal_sdk = */ true, + /* .expect_sdk_path_pattern = */ "iPhoneOS14.1.Internal.sdk"}, }; INSTANTIATE_TEST_SUITE_P(SDKPathParsingTests, SDKPathParsingMultiparamTests, _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
