clayborg added a comment.

So std::vector shouldn't be used in a public API. You should make a class that 
wraps your objects. LLDB's public API has lldb::SBInstruction and 
lldb::SBInstructionList as examples. std::vector on other systems compiles 
differently for debug and release builds and things will crash. If you need 
this via swig for internal kind of stuff, then use a typemap where you map 
std::vector<T> to a list() with T instances in it in python.

I am a bit confused here as well. Are we exporting a plug-in specific python 
bindings for the Intel PT data? It seems like it would be nice to wrap this API 
into the SBTrace or other lldb interface? Am I not understanding this correctly?


https://reviews.llvm.org/D33035



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to