JDevlieghere wrote: > > So the confusion error message is because we're interpreting the data > > incorrectly, right? There's no opportunity to improve it, because based on > > what it thinks is on the stack, it is "correct"? > > such as: <img alt="image" width="2000" height="89" > src="https://private-user-images.githubusercontent.com/72311224/602594459-e1495436-a021-4004-886c-cedafb696cca.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA1NDk4OTMsIm5iZiI6MTc4MDU0OTU5MywicGF0aCI6Ii83MjMxMTIyNC82MDI1OTQ0NTktZTE0OTU0MzYtYTAyMS00MDA0LTg4NmMtY2VkYWZiNjk2Y2NhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjA0VDA1MDYzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAwNjE1ZDJhMjY0MzBiZWNiMTlhOGY3OTQ0YzBjOTVmNjU1OGFjMjc0MzEzYjAzNDE4Y2ExMzZiMDVjNjY1MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.83oQ8IsL6OYcODH0PCU_EdD1jSPN6Vop6Gq43lZZgho";>
That doesn't really answer my question. Let me know if what I'm asking is not clear. > > Thanks for the shell test. We also have extensive tests for the DWARF > > expression evaluator in our unit tests, can you please also add coverage > > there? > > Only GetOpcodeDataSize() is affected — the evaluation path already handles > DW_OP_implicit_value correctly. The shell test is the appropriate place to > cover this fix. I'm not sure I understand. Can you explain why this cannot be unit tested? https://github.com/llvm/llvm-project/pull/201344 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
![https://private-user-images.githubusercontent.com/72311224/602594459-e1495436-a021-4004-886c-cedafb696cca.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA1NDk4OTMsIm5iZiI6MTc4MDU0OTU5MywicGF0aCI6Ii83MjMxMTIyNC82MDI1OTQ0NTktZTE0OTU0MzYtYTAyMS00MDA0LTg4NmMtY2VkYWZiNjk2Y2NhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjA0VDA1MDYzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAwNjE1ZDJhMjY0MzBiZWNiMTlhOGY3OTQ0YzBjOTVmNjU1OGFjMjc0MzEzYjAzNDE4Y2ExMzZiMDVjNjY1MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.83oQ8IsL6OYcODH0PCU_EdD1jSPN6Vop6Gq43lZZgho"](https://private-user-images.githubusercontent.com/72311224/602594459-e1495436-a021-4004-886c-cedafb696cca.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODA1NDk4OTMsIm5iZiI6MTc4MDU0OTU5MywicGF0aCI6Ii83MjMxMTIyNC82MDI1OTQ0NTktZTE0OTU0MzYtYTAyMS00MDA0LTg4NmMtY2VkYWZiNjk2Y2NhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjA0VDA1MDYzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAwNjE1ZDJhMjY0MzBiZWNiMTlhOGY3OTQ0YzBjOTVmNjU1OGFjMjc0MzEzYjAzNDE4Y2ExMzZiMDVjNjY1MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.83oQ8IsL6OYcODH0PCU_EdD1jSPN6Vop6Gq43lZZgho"){kind=link}