chsigg wrote:

> I think t his PR has a bug in it. It tries to call 
> ScriptInterpeterRuntimeLoader::Get in SystemInitializeFull.cpp if 
> LLDB_ENABLE_PYTHON is TRUE; but in ScriptInterpereterRunTimeLoader, that 
> function is only defined if LLDB_ENABLE_PYTHON is FALSE. Please fix this asap!

I think this works as intended.

- `PythonRuntimeLoader.cpp` also defines `ScriptInterpeterRuntimeLoader::Get`, 
and is included in the build if (cmake)  `LLDB_ENABLE_PYTHON=TRUE`.  
- `ScriptInterpreterRuntimeLoader.cpp` is always included in the build, but the 
function implementation is guarded by (c preprocessor) `#if 
!LLDB_ENABLE_PYTHON`.

https://github.com/llvm/llvm-project/pull/200530
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to