jimingham wrote: LGTM with mostly comment comments. Also, is there any reason to have ReadTryLock and ReadUnlock public methods of ProcessRunLock? I couldn't find any external uses of the API's, and this change has made them unsafe to use outside it.
It seems to me like all the external clients are going to use the pattern: Get the runlocker, do some stuff and release it. So there shouldn't be any external need to use ReadTryLock & ReadUnlock. I can't see any reason to keep them public members. https://github.com/llvm/llvm-project/pull/201685 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
