llvmorg-github-actions[bot] wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

This patch makes the Windows `RM_RF` a no-op on an empty argument and swallow 
errors, matching Unix `rm -rf`. This fixes issues in swiftlang on fresh builds.

---
Full diff: https://github.com/llvm/llvm-project/pull/203040.diff


1 Files Affected:

- (modified) lldb/packages/Python/lldbsuite/test/make/Makefile.rules (+1-1) 


``````````diff
diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules 
b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index 44aa91ef7b6fc..f4318299c1164 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -44,7 +44,7 @@ ifeq "$(OS)" "Windows_NT"
        CP_R = xcopy $(subst /,\,$(1)) $(subst /,\,$(2)) /s /e /y
        RM = del $(subst /,\,$(1)) > nul 2>&1 || (exit 0)
        RM_F = del /f /q $(subst /,\,$(1))
-       RM_RF = rd /s /q $(subst /,\,$(1))
+       RM_RF = $(if $(strip $(1)),rd /s /q $(subst /,\,$(1)) > nul 2>&1 || 
(exit 0))
        LN_SF = mklink /D "$(subst /,\,$(2))" "$(subst /,\,$(1))"
        ECHO = echo $(1);
        ECHO_TO_FILE = printf "%s\n" $(1) > "$(subst /,\,$(2))"

``````````

</details>


https://github.com/llvm/llvm-project/pull/203040
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to