================
@@ -33,31 +34,32 @@ class StreamGDBRemote : public StreamString {
/// Output a block of data to the stream performing GDB-remote escaping.
///
- /// \param[in] s
+ /// \param[in] bytes
/// A block of data.
///
- /// \param[in] src_len
- /// The amount of data to write.
- ///
/// \return
/// Number of bytes written.
- // TODO: Convert this function to take ArrayRef<uint8_t>
- int PutEscapedBytes(const void *s, size_t src_len);
-
- /// Equivalent to PutEscapedBytes(str.data(), str.size());
- int PutEscapedBytes(llvm::StringRef str);
+ int PutEscapedBytes(llvm::ArrayRef<uint8_t> bytes);
----------------
walter-erquinigo wrote:
@JDevlieghere , I know that we often use StringRef for bytes, but this actually
makes it more explicit that we have bytes instead of chars. What do you think?
https://github.com/llvm/llvm-project/pull/203175
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
