jasonmolenda wrote: Added a testcase with a riscv32 corefile API test case I already had.
Found & fixed two places where m_current_offset and m_current_offset_backed_up_one in RegisterContextUnwind() were changed to std::optional<int> last year, but they were still being used as if they were simple integral type and that would result in no compiler errors/warnings. More argument for the idea @jimingham and I were discussing recently where we should have a naming convention for optional ivars like `m_opt_current_offset` to make it a tiny bit easier to spot this kind of thing. https://github.com/llvm/llvm-project/pull/203684 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
