omjavaid wrote: Sorry for the delayed review.
Thanks for the patch. InitializeContext based heap buffer approach makes sense for extended state support. My concern is that it seems like an isolated change without an overall plan for SVE on WoA. We have spent years building SVE, MTE, PAC, SME support on Linux arm64 side and it will be a real waste if we dont leverage some of that on other platforms. Some of the logic currently living in NativeRegisterContextLinux_arm64 can be generalized and moved up so it can be shared across platforms. What i would like to see before we start implementing changes around SVE on windows side is a refactor that generalizes the relevant Linux arm64 logic first and maximizes reuse. That way the windows SVE implementation can build on a shared foundation rather than duplicating everything from scratch. Can you share what the intended end state looks like around WoA SVE implementation. https://github.com/llvm/llvm-project/pull/200898 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
