https://github.com/labath approved this pull request.

Okay, I think I understand the issue.

ApplyTerminalSizeChange is called on the reading thread but we don't know when 
will that happen w.r.t the async output thread, so you make sure it calls 
ApplyTerminalSizeChange.

That makes sense, though I also wonder if it would be possible to call 
ApplyTerminalSizeChange eagerly (as soon as we get the window change signal). 
We originally couldn't do that because we were in the signal handler, but it 
might be possible now that the handling happens inside a thread.

https://github.com/llvm/llvm-project/pull/203045
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to