================
@@ -50,6 +51,8 @@ if (LLDB_ENABLE_DYNAMIC_SCRIPTINTERPRETERS)
   # plugin is built with allow-undefined-symbol semantics on POSIX.
   add_lldb_library(lldbPluginScriptInterpreterPython SHARED
     ${python_plugin_sources}
+    LINK_COMPONENTS
+      ${shared_python_plugin_link_components}
----------------
Nerixyz wrote:

With this PR, we fail to launch, because 
`lldb_initialize_ScriptInterpreterPython` isn't exported from the DLL.

> This would mean that lldbPluginScriptInterpreterPython and liblldb would both 
> have the Support symbols in them.

Yes and no: They duplicate the code, but on Windows, all symbols are hidden in 
DLLs by default (as-if it was compiled with `-fvisibility=hidden`). So we don't 
have any symbol conflicts at runtime.

> Shouldn't the python dylib pick up these symbols from liblldb via that 
> exports file?

The exports file isn't generated on Windows: 
https://github.com/llvm/llvm-project/blob/6d895d02e95218907633d77ddfabd1368643938d/lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt#L75-L78

https://github.com/llvm/llvm-project/pull/200843
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to