================ @@ -58,6 +58,54 @@ most cases. This significantly restructures how ``function`` is written to provide better performance, but is currently not ABI stable. +``_LIBCPP_ABI_VECTOR_LAYOUT`` ---------------- ldionne wrote:
I like that we're documenting the ABI macro here, I think that was an oversight in previous versions of the patch. However, the name of the macro is `_LIBCPP_ABI_SIZE_BASED_VECTOR`, and `_LIBCPP_ABI_VECTOR_LAYOUT_POINTER_BASED` / `_LIBCPP_ABI_VECTOR_LAYOUT_SIZE_BASED` don't exist. Instead, I think we should follow the style used to document other macros a bit more closely. I'd suggest: ``` ``_LIBCPP_ABI_SIZE_BASED_VECTOR`` ----------------------------------------- This changes the layout of `std::vector` from <...> to <...>. ``` You can keep the meat of your current documentation in the `<...>` in a form that makes sense. https://github.com/llvm/llvm-project/pull/155330 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
