https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/206179
>From ab6c46dafbfa32583eba914002f211b2e399d994 Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Fri, 26 Jun 2026 21:50:57 +0100 Subject: [PATCH 1/3] [lldb][windows] fix always falsy comparison --- .../lldbsuite/test/tools/lldb-server/gdbremote_testcase.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py index b278066e3a671..ede6ea8490951 100644 --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py @@ -559,7 +559,7 @@ def do_handshake(self): server.send_ack() def add_verified_launch_packets(self, launch_args): - if os.environ.get("LLDB_LAUNCH_FLAG_USE_PIPES", 0) == 1: + if os.environ.get("LLDB_LAUNCH_FLAG_USE_PIPES", "0") == "1": self.test_sequence.add_log_lines( [ "read packet: %s" >From a457b19d9f318aa0828820072e92845a05c8387d Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Sat, 27 Jun 2026 17:55:54 +0100 Subject: [PATCH 2/3] fixup! [lldb][windows] fix always falsy comparison --- lldb/test/API/tools/lldb-server/main.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/lldb/test/API/tools/lldb-server/main.cpp b/lldb/test/API/tools/lldb-server/main.cpp index bbe523fc3c2f7..c37f815430e93 100644 --- a/lldb/test/API/tools/lldb-server/main.cpp +++ b/lldb/test/API/tools/lldb-server/main.cpp @@ -402,6 +402,7 @@ int main(int argc, char **argv) { } else { // Treat the argument as text for stdout. printf("%s\n", argv[i]); + fflush(stdout); } } >From 2f0deeab9975b9d856187ebd17beb0f899a4cc50 Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Mon, 29 Jun 2026 15:00:14 +0100 Subject: [PATCH 3/3] add comment --- lldb/test/API/tools/lldb-server/main.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/lldb/test/API/tools/lldb-server/main.cpp b/lldb/test/API/tools/lldb-server/main.cpp index c37f815430e93..eabe2bc886b85 100644 --- a/lldb/test/API/tools/lldb-server/main.cpp +++ b/lldb/test/API/tools/lldb-server/main.cpp @@ -402,6 +402,7 @@ int main(int argc, char **argv) { } else { // Treat the argument as text for stdout. printf("%s\n", argv[i]); + // Make the test more reliable on Windows. fflush(stdout); } } _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
