jasonmolenda wrote:

Ah, I apologize.  Your PR is noting that we have an X86 base class method that 
is currently calling Target.GetArchtiecture to know if this is 64- or 32-bit.  
But the actual subclasses that are instantiated are either i386 or x86_64, so 
adding a subclass method that specifies the correct bitsize is a reasonable 
approach.

You're right, your PR is good.

https://github.com/llvm/llvm-project/pull/203498
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to