https://github.com/JDevlieghere commented:
IIRC, `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` was introduced specifically for testing purposes. This PR indirectly achieves its goal by relying on the fact that we don't shell out to the real dsymForUUID (potentially through DebugSymbols.framework) because all code paths should check this environment variable first. If that's indeed the case, then I think this is fine. I do wonder if we should have a less roundabout way of doing this. For example, something like a setting that disables symbol lookup at the plugin level so we don't do the same thing for debuginfod. https://github.com/llvm/llvm-project/pull/201547 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
