Author: Sylvestre Ledru Date: 2026-07-02T11:58:47+02:00 New Revision: 4f11992ff68d3d872fe72317675b29343d10c1fe
URL: https://github.com/llvm/llvm-project/commit/4f11992ff68d3d872fe72317675b29343d10c1fe DIFF: https://github.com/llvm/llvm-project/commit/4f11992ff68d3d872fe72317675b29343d10c1fe.diff LOG: [lldb] Fix build after FileSpec::GetDirectory() ConstString removal (#207073) FileSpec::GetDirectory() now returns llvm::StringRef instead of ConstString, so the .GetStringRef() call no longer compiles. Regressed by f9b5264523b1 ("[lldb] Remove ConstString getters from FileSpec", #206802). failed with ``` /build/source/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp:276:44: error: no member named 'GetStringRef' in 'llvm::StringRef' 276 | path_to_copy_module.GetDirectory().GetStringRef()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. ``` Added: Modified: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp index 3827750d2f489..fc0620428a7bd 100644 --- a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp +++ b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp @@ -272,8 +272,7 @@ BuildModulesSection(Process &process, FileSpec directory) { FileSpec path_to_copy_module = directory; path_to_copy_module.AppendPathComponent("modules"); path_to_copy_module.AppendPathComponent(system_path); - sys::fs::create_directories( - path_to_copy_module.GetDirectory().GetStringRef()); + sys::fs::create_directories(path_to_copy_module.GetDirectory()); if (std::error_code ec = llvm::sys::fs::copy_file(file, path_to_copy_module.GetPath())) _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
