https://github.com/jimingham commented:
This is okay. The real problem here is that when code in the _lldb_init_module does a HandleCommand that returns an error, we will report that error w/o telling you which HandleCommand failed. This change only makes the case where the command was `command script add` more understandable. Also, you don't actually know a priori that the only way to get to AddUserCommand was `command script add`, after all that also gets called by SBCommandInterpreter::AddCommand as well. You luck out right now, because we always pass "overwrite = True" in the SB API's, so you would only get this error from `command script add`. That's not a guarantee in the future, so we need to remind ourselves that if we ever add an AddCommand that takes an overwrite flag, we'd need to update the error message... https://github.com/llvm/llvm-project/pull/207141 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
