llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) <details> <summary>Changes</summary> lldb does not check if the instruction was decoded correctly. This causes an assertion failure when starting lldb-dap on Windows with lldb-server. Requires: - https://github.com/llvm/llvm-project/pull/208277. --- Full diff: https://github.com/llvm/llvm-project/pull/208279.diff 1 Files Affected: - (modified) lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp (+1-1) ``````````diff diff --git a/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp b/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp index a18c95bdbde98..fe59e988e3cd9 100644 --- a/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp +++ b/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp @@ -530,7 +530,7 @@ class InstructionLLVMC : public lldb_private::Instruction { m_is_valid = mc_disasm_ptr->GetMCInst(opcode_data, opcode_data_len, pc, inst, inst_size); m_opcode.Clear(); - if (inst_size != 0) { + if (m_is_valid && inst_size != 0) { if (arch.GetTriple().isRISCV()) m_opcode.SetOpcode16_32TupleBytes(opcode_data, inst_size, byte_order); `````````` </details> https://github.com/llvm/llvm-project/pull/208279 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
