da-viper wrote: > I'm confused: why did you drop the non-virtual Clear method that called the > virtual ClearImpl? The current version is easy to misuse.
I changed it because. `Clear` is not the only abstract function that may race (there is `DumpValue`, `ToJSON` and `Clone`). This means creating the same `FuncImpl` pattern. But some `OptionValue` Type may have extra function with a lock and wonder why the `XXXXImpl` doesn't have one. Removed so it is consistent. https://github.com/llvm/llvm-project/pull/208471 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
